martinzink commented on a change in pull request #1225:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1225#discussion_r782326329
##########
File path: extensions/mqtt/controllerservice/MQTTControllerService.h
##########
@@ -293,8 +289,8 @@ class MQTTControllerService : public
core::controller::ControllerService {
MQTTClient client_;
std::string uri_;
std::string topic_;
- int64_t keepAliveInterval_;
- int64_t connectionTimeOut_;
+ std::chrono::milliseconds keepAliveInterval_{0};
+ std::chrono::milliseconds connectionTimeOut_{0};
Review comment:
I will create a separate ticket and investigate, because the
MQTTControllerService::reconnect relies on some of these uninitialized members
and the AbstractMQTTProcessor and MQTTControllerService have a lot of duplicate
codes.
I wouldnt be suprised if there are some bugs here or there.
Anyways I fixed the timeout typos throughout the code in
https://github.com/apache/nifi-minifi-cpp/pull/1225/commits/63a26de4232196b77a7a366ad95f99a3a62fc598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
