martinzink commented on a change in pull request #1225:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1225#discussion_r782298296
##########
File path: extensions/mqtt/controllerservice/MQTTControllerService.h
##########
@@ -293,8 +289,8 @@ class MQTTControllerService : public
core::controller::ControllerService {
MQTTClient client_;
std::string uri_;
std::string topic_;
- int64_t keepAliveInterval_;
- int64_t connectionTimeOut_;
+ std::chrono::milliseconds keepAliveInterval_{0};
+ std::chrono::milliseconds connectionTimeOut_{0};
Review comment:
you are right I do seem to have skipped this, probably because it is not
used anywhere :confused:
i've looked at MQTTControllerService and it has a bunch of properties and
matching members that are not used anywhere as far as I could tell.
from BrokerURL, ClientID, CleanSession, UserName, Password,
KeepLiveInterval, ConnectionTimeout, QOS Topic, SecurityProtocol only BrokerURL
and ClientID is used in onEnable
Am i missing something ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
