martinzink commented on a change in pull request #1225:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1225#discussion_r782244586
##########
File path: libminifi/include/utils/TimeUtil.h
##########
@@ -197,6 +193,91 @@ inline bool getDateTimeStr(int64_t unix_timestamp,
std::string& date_time_str) {
return true;
}
+namespace details {
+
+template<class Duration>
+bool unit_matches(const std::string&) {
+ return false;
+}
+
+template<>
+inline bool unit_matches<std::chrono::nanoseconds>(const std::string& unit) {
+ return unit == "ns" || unit == "nano" || unit == "nanos" || unit ==
"nanoseconds";
+}
+
+template<>
+inline bool unit_matches<std::chrono::microseconds>(const std::string& unit) {
+ return unit == "us" || unit == "micro" || unit == "micros" || unit ==
"microseconds" || unit == "microsecond";
+}
+
+template<>
+inline bool unit_matches<std::chrono::milliseconds>(const std::string& unit) {
+ return unit == "msec" || unit == "ms" || unit == "millisecond" || unit ==
"milliseconds" || unit == "msecs" || unit == "millis" || unit == "milli";
+}
+
+template<>
+inline bool unit_matches<std::chrono::seconds>(const std::string& unit) {
+ return unit == "sec" || unit == "s" || unit == "second" || unit == "seconds"
|| unit == "secs";
+}
+
+template<>
+inline bool unit_matches<std::chrono::minutes>(const std::string& unit) {
+ return unit == "min" || unit == "m" || unit == "mins" || unit == "minute" ||
unit == "minutes";
+}
+
+template<>
+inline bool unit_matches<std::chrono::hours>(const std::string& unit) {
+ return unit == "h" || unit == "hr" || unit == "hour" || unit == "hrs" ||
unit == "hours";
+}
+
+template<>
+inline bool unit_matches<std::chrono::days>(const std::string& unit) {
+ return unit == "d" || unit == "day" || unit == "days";
+}
+
+
+template<class TargetDuration, class SourceDuration>
+std::optional<TargetDuration> cast_if_unit_matches(const std::string& unit,
const int64_t value) {
+ if (unit_matches<SourceDuration>(unit)) {
+ return std::chrono::duration_cast<TargetDuration>(SourceDuration(value));
+ } else {
+ return std::nullopt;
+ }
+}
+
+template<class TargetDuration, typename... T>
+std::optional<TargetDuration> cast_to_matching_unit(std::string& unit, const
int64_t value) {
+ std::optional<TargetDuration> result;
+ ((result = cast_if_unit_matches<TargetDuration, T>(unit, value)) || ...);
+ return result;
+}
+
+inline bool get_unit_and_value(const std::string& input, std::string& unit,
int64_t& value) {
+ std::stringstream input_stream(input);
+ input_stream >> value >> unit;
+ std::transform(unit.begin(), unit.end(), unit.begin(), ::tolower);
+ return !input_stream.fail();
+}
Review comment:
space is not required (e.g. 5s is valid), but I agree with you and
sstream is quite slow compared to other methods so I reverted this to the
original implementation in
https://github.com/apache/nifi-minifi-cpp/pull/1225/commits/9f0c3752c6a328e005bb22a566eceb406c7fe348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
