greyp9 opened a new pull request #5787:
URL: https://github.com/apache/nifi/pull/5787
#### Description of PR
Various code fixes related to Github/CI system test failures.
- Capture troubleshooting data on job timeout.
- Capture `maven-failsafe-plugin` output on job failure.
- System test timing adjustments to reduce diagnostic noise.
- Log PID on startup / shutdown to identify source of orphaned processes.
- Fix for `LoadBalanceSession` handshake failure (which causes test
timeouts).
- Fix for `LoadBalanceSession` session wrapup (which can cause test
timeouts).
- Logging allowing for identification of load balance failures.
- Retry NiFi process shutdown if needed during system test case teardown.
- Fix logging typo.
- Log IDs of both ends of LoadBalance connections (to help identify failure
cases).
- Retry ReportingTask query on incomplete response.
- Do not mask `InterruptedException` while waiting for system test actions
to complete.
- Retry service queries until expected state is verified.
- Short waits between actions (when needed) to allow FlowManager state to
become consistent.
- Comment out ReportingTask system test failures to allow NIFI-9717 to be
addressed asynchronously.
- Adjust system test cluster configuration to avoid test failure condition.
- Adjust `logback` logging for system test profile (include timestamps).
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
