greyp9 commented on pull request #5787: URL: https://github.com/apache/nifi/pull/5787#issuecomment-1057507510
> @greyp9, in order to continue progress on this pull request, what do you think about separating the `nifi-bootstrap` changes into a separate PR? Including the Process ID looks like a useful runtime adjustment, regardless of system integration tests. Those changes could be reviewed and incorporated separately from the integration test improvements. Thanks @exceptionfactory for the feedback. Looking at this PR as a whole, I agree that it should be broken out, and I'm in the process of doing that. I'll close this PR in favor of those. > The runtime change to `LoadBalanceSession` also seems worth considering separately, but in that case, I'm not sure that hard-coding a one second read timeout makes sense in all cases. Yep. The one second timeout only affects the server ACK part of LoadBalance protocol. I tried it out in response to direct evidence of an issue with that part of the protocol, and things ran much better on the github CI machines. But I agree it looks icky. Something is going on there that needs further investigation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
