exceptionfactory commented on a change in pull request #5787:
URL: https://github.com/apache/nifi/pull/5787#discussion_r817704940
##########
File path:
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/ShutdownHook.java
##########
@@ -66,7 +68,7 @@ public void run() {
}
runner.notifyStop();
- System.out.println("Waiting for Apache NiFi to finish shutting
down...");
+ System.out.println("Waiting for Apache NiFi to finish shutting down...
pid=" + pid);
Review comment:
Also recommend adjusting this message:
```suggestion
System.out.printf("NiFi process [%d] shutdown in progress...%n",
pid);
```
##########
File path:
nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/ShutdownHook.java
##########
@@ -51,7 +53,7 @@ public void run() {
runner.setAutoRestartNiFi(false);
final int ccPort = runner.getNiFiCommandControlPort();
if (ccPort > 0) {
- System.out.println("Initiating Shutdown of NiFi...");
+ System.out.println("Initiating Shutdown of NiFi... pid=" + pid);
Review comment:
Recommend the following in relationship to the comment on `RunNiFi`, as
well as adjusting the method call to use `printf()` for formatting:
```suggestion
System.out.printf("NiFi process [%d] shutdown started%n", pid);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
