exceptionfactory commented on a change in pull request #5787:
URL: https://github.com/apache/nifi/pull/5787#discussion_r814465728
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/clustered/server/ConnectionLoadBalanceServer.java
##########
@@ -169,8 +169,10 @@ public void run() {
break;
}
} catch (final Exception e) {
+ stopped = true;
if (socket != null) {
try {
+ logger.debug("closing socket");
Review comment:
This logging statement should include more details about the connection.
##########
File path:
nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/verification/ClusteredVerifiableControllerServiceSystemIT.java
##########
@@ -57,6 +57,6 @@ public void testDifferentResultsFromDifferentNodes() throws
InterruptedException
// Second verification result will be verification results
assertEquals(Outcome.SUCCESSFUL.name(),
resultList.get(1).getOutcome());
// Third verification result is for Fail On Primary Node
- assertEquals(Outcome.FAILED.name(), resultList.get(2).getOutcome());
+ // assertEquals(Outcome.FAILED.name(),
resultList.get(2).getOutcome()); // NIFI-9717
Review comment:
Rather than commenting out this assertion, it seems like it should be
removed, then evaluated in the ticket mentioned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
