fgerlits commented on a change in pull request #1252:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816078921
##########
File path: extensions/standard-processors/processors/GetTCP.h
##########
@@ -269,10 +268,10 @@ class GetTCP : public core::Processor, public
state::response::MetricsNodeSource
std::shared_ptr<minifi::controllers::SSLContextService> ssl_service_;
- // last listing time for root directory ( if recursive, we will consider the
root
- // as the top level time.
-
std::shared_ptr<core::logging::Logger> logger_ =
core::logging::LoggerFactory<GetTCP>::getLogger();
+
+ // thread pool must be the last, as it is first to be destructed before
other members, otherwise segfault is possible
Review comment:
I see, thanks. A better solution could be to add a destructor which
calls `client_thread_pool_.shutdown()`, and then we wouldn't need to rely on
the ordering of the members.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
