adam-markovics commented on a change in pull request #1252:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816095354
##########
File path: libminifi/include/core/ProcessGroup.h
##########
@@ -176,29 +170,27 @@ class ProcessGroup : public CoreComponent {
parent_process_group_ = parent;
}
// get parent process group
- ProcessGroup *getParent(void) {
+ ProcessGroup *getParent() {
std::lock_guard<std::recursive_mutex> lock(mutex_);
return parent_process_group_;
}
// Add processor
- void addProcessor(const std::shared_ptr<Processor>& processor);
- // Remove processor
- void removeProcessor(const std::shared_ptr<Processor>& processor);
+ void addProcessor(std::unique_ptr<Processor> processor);
// Add child processor group
void addProcessGroup(std::unique_ptr<ProcessGroup> child);
// ! Add connections
- void addConnection(const std::shared_ptr<Connection>& connection);
+ void addConnection(std::unique_ptr<Connection>&& connection);
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
