adam-markovics commented on a change in pull request #1252:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816093694
##########
File path: docker/test/integration/minifi/core/TransientMinifiContainer.py
##########
@@ -0,0 +1,8 @@
+from .MinifiContainer import MinifiContainer
+
+
+class TransientMinifiContainer(MinifiContainer):
+ def __init__(self, config_dir, name, vols, network, image_store,
command=None):
+ if not command:
+ command = ["/bin/sh", "-c", "cp /tmp/minifi_config/config.yml " +
MinifiContainer.MINIFI_ROOT + "/conf &&
/opt/minifi/minifi-current/bin/minifi.sh start && sleep 10 &&
/opt/minifi/minifi-current/bin/minifi.sh stop && sleep 100"]
Review comment:
Done.
##########
File path: extensions/script/python/PythonProcessor.cpp
##########
@@ -32,33 +32,30 @@ namespace python {
namespace py = pybind11;
namespace core = org::apache::nifi::minifi::core;
-PythonProcessor::PythonProcessor(std::shared_ptr<core::Processor> proc) {
- processor_ =
std::dynamic_pointer_cast<python::processors::ExecutePythonProcessor>(proc);
+PythonProcessor::PythonProcessor(core::Processor* proc) {
+ processor_ = dynamic_cast<python::processors::ExecutePythonProcessor*>(proc);
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
