adam-markovics commented on a change in pull request #1252:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1252#discussion_r816091151
##########
File path: extensions/http-curl/tests/C2ClearCoreComponentStateTest.cpp
##########
@@ -50,10 +50,10 @@ class VerifyC2ClearCoreComponentState : public VerifyC2Base
{
}
protected:
- void updateProperties(std::shared_ptr<minifi::FlowController>
flow_controller) override {
-
std::dynamic_pointer_cast<minifi::state::ProcessorController>(flow_controller->getComponents("TailFile1")[0])
+ void updateProperties(std::unique_ptr<minifi::FlowController>&
flow_controller) override {
Review comment:
Done.
##########
File path: extensions/libarchive/BinFiles.cpp
##########
@@ -346,10 +346,10 @@ void BinFiles::restore(const
std::shared_ptr<core::FlowFile>& flowFile) {
file_store_.put(flowFile);
}
-std::set<std::shared_ptr<core::Connectable>>
BinFiles::getOutGoingConnections(const std::string &relationship) const {
+std::set<core::Connectable*> BinFiles::getOutGoingConnections(const
std::string &relationship) const {
auto result = core::Connectable::getOutGoingConnections(relationship);
if (relationship == Self.getName()) {
-
result.insert(std::static_pointer_cast<core::Connectable>(std::const_pointer_cast<core::Processor>(shared_from_this())));
+ result.insert(const_cast<BinFiles*>(this));
Review comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
