adamdebreceni commented on code in PR #1334:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1334#discussion_r886761331
##########
libminifi/include/controllers/keyvalue/AbstractAutoPersistingKeyValueStoreService.h:
##########
@@ -30,23 +29,17 @@
#include "core/logging/LoggerConfiguration.h"
#include "utils/Export.h"
-
-namespace org {
-namespace apache {
-namespace nifi {
-namespace minifi {
-namespace controllers {
+namespace org::apache::nifi::minifi::controllers {
class AbstractAutoPersistingKeyValueStoreService : virtual public
PersistableKeyValueStoreService {
public:
explicit AbstractAutoPersistingKeyValueStoreService(const std::string& name,
const utils::Identifier& uuid = {});
~AbstractAutoPersistingKeyValueStoreService() override;
- MINIFIAPI static core::Property AlwaysPersist;
- MINIFIAPI static core::Property AutoPersistenceInterval;
+ static constexpr const char* AlwaysPersistPropertyName = "Always Persist";
+ static constexpr const char* AutoPersistenceIntervalPropertyName = "Auto
Persistence Interval";
Review Comment:
what is the reason behind this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
