szaszm commented on PR #1409: URL: https://github.com/apache/nifi-minifi-cpp/pull/1409#issuecomment-1239242437
Instead of introducing "UrlUrils", I'd prefer to model URLs in their own class, similar to `std::filesystem::path`. On Tue, Sep 6, 2022, 18:30 Ferenc Gerlits ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In extensions/sftp/processors/ListSFTP.cpp > <https://github.com/apache/nifi-minifi-cpp/pull/1409#discussion_r963854386> > : > > > @@ -186,7 +186,7 @@ ListSFTP::Child::Child(const std::string& parent_path_, std::tuple<std::string / > } > > std::string ListSFTP::Child::getPath() const { > - return utils::file::FileUtils::concat_path(parent_path, filename, true /*force_posix*/); > + return utils::StringUtils::join_pack(parent_path, "/", filename); > > This is not used for files, only for URLs, so I wouldn't put it in > FileUtils. I can add a makeUrl() function in StringUtils (or maybe a new > UrlUtils) which joins its argument with '/'s. I think that would be less > explicit, but it may be more readable. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/nifi-minifi-cpp/pull/1409#discussion_r963854386>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAI5ZFR2A5UEAIRM4S6YVSLV45PPPANCNFSM576ECTXA> > . > You are receiving this because you commented.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
