fgerlits commented on code in PR #1409:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1409#discussion_r968166094
##########
extensions/sftp/processors/ListSFTP.cpp:
##########
@@ -186,7 +186,7 @@ ListSFTP::Child::Child(const std::string& parent_path_,
std::tuple<std::string /
}
std::string ListSFTP::Child::getPath() const {
- return utils::file::FileUtils::concat_path(parent_path, filename, true
/*force_posix*/);
+ return utils::StringUtils::join_pack(parent_path, "/", filename);
Review Comment:
`joinWithSlashes` is almost certainly slower than `join_pack`, because
`stringstream` is slower than `string::append()`, but I don't think it will be
called enough times to make a difference.
Readability-wise, I think both are fine -- we may need a 4th person to
decide, as now we have 1 yea, 1 nay, and 1 abstention.
Having path-like URL class is a good idea, but I don't want to do that in
this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
