szaszm commented on code in PR #1409:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1409#discussion_r967525401
##########
extensions/sftp/processors/ListSFTP.cpp:
##########
@@ -186,7 +186,7 @@ ListSFTP::Child::Child(const std::string& parent_path_,
std::tuple<std::string /
}
std::string ListSFTP::Child::getPath() const {
- return utils::file::FileUtils::concat_path(parent_path, filename, true
/*force_posix*/);
+ return utils::StringUtils::join_pack(parent_path, "/", filename);
Review Comment:
I'm not a fan of `joinWithSlashes`. I don't think this abstraction helps
with readability or performance. `join_pack` with slashes is just fine for URLs
IMO, but if you insist on a new abstraction layer, it should probably be a
class for URLs with a slash operator, like `std::filesystem::path`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
