lordgamez commented on code in PR #1409:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1409#discussion_r968173622
##########
extensions/sftp/processors/ListSFTP.cpp:
##########
@@ -186,7 +186,7 @@ ListSFTP::Child::Child(const std::string& parent_path_,
std::tuple<std::string /
}
std::string ListSFTP::Child::getPath() const {
- return utils::file::FileUtils::concat_path(parent_path, filename, true
/*force_posix*/);
+ return utils::StringUtils::join_pack(parent_path, "/", filename);
Review Comment:
My original intention was to extract the previous `concat_path` with
`force_posix` option to a separate function for easier access, as it seems to
be a common use case. With the last change I don't think `joinWithSlashes`
would be a better option, but this functionality as part of a URL utility class
is something that sounds better. If that wouldn't be a trivial change then I
think that can be delegated to a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
