fgerlits commented on code in PR #1409:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1409#discussion_r968245257
##########
extensions/sftp/processors/ListSFTP.cpp:
##########
@@ -186,7 +186,7 @@ ListSFTP::Child::Child(const std::string& parent_path_,
std::tuple<std::string /
}
std::string ListSFTP::Child::getPath() const {
- return utils::file::FileUtils::concat_path(parent_path, filename, true
/*force_posix*/);
+ return utils::StringUtils::join_pack(parent_path, "/", filename);
Review Comment:
OK, I have reverted 4a7c19f078eabede4cfd750fa513b73bc012e654.
`concat_path(..., force_posix = true)` wasn't used in many places, only in
`ListSFTP` (2 times) and `PutSFTP` (3 times). There may be more opportunities
to use a `URL` class, I haven't checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
