lordgamez opened a new pull request, #1497: URL: https://github.com/apache/nifi-minifi-cpp/pull/1497
Notable changes: - FlowController ise separated from C2Client - C2Client is separated by functionality to C2Agent and C2MetricsPublisher - MetricsPublisherStore is introduced to instantiate metrics publishers when configured through MetricsPublisherFactory - Response nodes are ensured to be not null - ConnectionStore is aggregated instead of inherited from - Root process group functionalities and flow change operations are moved to RootProcessGroupWrapper - ResponseNodeLoader is shared between metrics publishers - FlowConfiguration is shared between FlowController and ResponseNodeLoader - Unnecessary contructor parameters are removed from FlowController, metrics and C2 are made optional - Controller service provider update is centralized to the extracted FlowController::updateFromPayload function - ResponseNodeLoader's state now contains a pointer to the root process group - RestSender initialization crash avoided when controller is nullptr https://issues.apache.org/jira/browse/MINIFICPP-1869 ----------------- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
