lordgamez commented on code in PR #1497:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1497#discussion_r1107087132
##########
libminifi/include/core/state/nodes/MetricsBase.h:
##########
@@ -37,28 +37,28 @@ namespace org::apache::nifi::minifi::state::response {
class ResponseNode : public core::Connectable, public PublishedMetricProvider {
public:
ResponseNode()
- : core::Connectable("metric"),
- is_array_(false) {
+ : core::Connectable("metric"),
Review Comment:
You are right, I thought the double indentation is only needed if it
conflicts with the indentation of the implementation code under it, but the
[style
guide](https://google.github.io/styleguide/cppguide.html#Constructor_Initializer_Lists)
insists on 4 spaces all times, updated in
c71bdaa3378b7087a33b7bd5f9a6bf4c3dd8cff8
##########
libminifi/include/core/state/nodes/MetricsBase.h:
##########
@@ -37,28 +37,28 @@ namespace org::apache::nifi::minifi::state::response {
class ResponseNode : public core::Connectable, public PublishedMetricProvider {
public:
ResponseNode()
- : core::Connectable("metric"),
- is_array_(false) {
+ : core::Connectable("metric"),
+ is_array_(false) {
}
explicit ResponseNode(std::string name)
- : core::Connectable(std::move(name)),
- is_array_(false) {
+ : core::Connectable(std::move(name)),
+ is_array_(false) {
}
ResponseNode(std::string name, const utils::Identifier& uuid)
- : core::Connectable(std::move(name), uuid),
- is_array_(false) {
+ : core::Connectable(std::move(name), uuid),
+ is_array_(false) {
}
~ResponseNode() override = default;
- static std::vector<state::response::SerializedResponseNode>
serializeAndMergeResponseNodes(const
std::vector<std::shared_ptr<ResponseNode>>& nodes) {
+ static std::vector<SerializedResponseNode>
serializeAndMergeResponseNodes(const
std::vector<gsl::not_null<std::shared_ptr<ResponseNode>>>& nodes) {
Review Comment:
Updated in c71bdaa3378b7087a33b7bd5f9a6bf4c3dd8cff8
##########
libminifi/include/core/state/nodes/MetricsBase.h:
##########
@@ -159,7 +161,7 @@ class ObjectNode : public ResponseNode {
class ResponseNodeSource {
public:
virtual ~ResponseNodeSource() = default;
- virtual std::shared_ptr<ResponseNode> getResponseNodes() = 0;
+ virtual SharedResponseNode getResponseNodes() = 0;
Review Comment:
Good point, updated in c71bdaa3378b7087a33b7bd5f9a6bf4c3dd8cff8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
