adamdebreceni commented on code in PR #1497:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1497#discussion_r1107030708
##########
libminifi/include/core/state/nodes/MetricsBase.h:
##########
@@ -37,28 +37,28 @@ namespace org::apache::nifi::minifi::state::response {
class ResponseNode : public core::Connectable, public PublishedMetricProvider {
public:
ResponseNode()
- : core::Connectable("metric"),
- is_array_(false) {
+ : core::Connectable("metric"),
+ is_array_(false) {
}
explicit ResponseNode(std::string name)
- : core::Connectable(std::move(name)),
- is_array_(false) {
+ : core::Connectable(std::move(name)),
+ is_array_(false) {
}
ResponseNode(std::string name, const utils::Identifier& uuid)
- : core::Connectable(std::move(name), uuid),
- is_array_(false) {
+ : core::Connectable(std::move(name), uuid),
+ is_array_(false) {
}
~ResponseNode() override = default;
- static std::vector<state::response::SerializedResponseNode>
serializeAndMergeResponseNodes(const
std::vector<std::shared_ptr<ResponseNode>>& nodes) {
+ static std::vector<SerializedResponseNode>
serializeAndMergeResponseNodes(const
std::vector<gsl::not_null<std::shared_ptr<ResponseNode>>>& nodes) {
Review Comment:
should we use the `SharedResponseNode` alias here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
