adamdebreceni commented on code in PR #1497:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1497#discussion_r1107031922
##########
libminifi/include/core/state/nodes/MetricsBase.h:
##########
@@ -159,7 +161,7 @@ class ObjectNode : public ResponseNode {
class ResponseNodeSource {
public:
virtual ~ResponseNodeSource() = default;
- virtual std::shared_ptr<ResponseNode> getResponseNodes() = 0;
+ virtual SharedResponseNode getResponseNodes() = 0;
Review Comment:
can this return more than one response nodes? should we drop the `s`?
##########
libminifi/include/core/state/nodes/MetricsBase.h:
##########
@@ -159,7 +161,7 @@ class ObjectNode : public ResponseNode {
class ResponseNodeSource {
public:
virtual ~ResponseNodeSource() = default;
- virtual std::shared_ptr<ResponseNode> getResponseNodes() = 0;
+ virtual SharedResponseNode getResponseNodes() = 0;
Review Comment:
can this return more than one response node? should we drop the `s`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
