martinzink commented on code in PR #1543:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155856612
##########
libminifi/test/unit/StringUtilsTests.cpp:
##########
@@ -536,4 +536,25 @@ TEST_CASE("StringUtils::matchesSequence works correctly",
"[matchesSequence]") {
REQUIRE(StringUtils::matchesSequence("xxxabcxxxabcxxxdefxxx", {"abc", "abc",
"def"}));
REQUIRE(!StringUtils::matchesSequence("xxxabcxxxdefxxx", {"abc", "abc",
"def"}));
}
+
+TEST_CASE("StringUtils::splitToUnitAndValue tests") {
Review Comment:
I've included these tests (except for the 017 bananas that would parse as 17
"bananas", and "0x17 bananas" would parse as 0 "x17 bananas")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
