martinzink commented on PR #1543:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#issuecomment-1494588704
> Another error popped up, this time in clang-tidy:
>
> ```
>
/home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/sftp/processors/../client/SFTPClient.h:20:10:
error: 'curl/curl.h' file not found [clang-diagnostic-error]
> #include <curl/curl.h>
> ^~~~~~~~~~~~~
>
/home/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/extensions/sftp/processors/SFTPProcessorBase.cpp:186:133:
error: parameter 'connection' is unused
[misc-unused-parameters,-warnings-as-errors]
> void SFTPProcessorBase::addConnectionToCache(const
SFTPProcessorBase::ConnectionCacheKey& key,
std::unique_ptr<utils::SFTPClient>&& connection) {
>
^~~~~~~~~~
>
/*connection*/
> ```
This seems false positive to me...
[Connection is used (it is moved into
connections_)](https://github.com/apache/nifi-minifi-cpp/blob/main/extensions/sftp/processors/SFTPProcessorBase.cpp#L203)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
