martinzink commented on code in PR #1543:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1543#discussion_r1155851899
##########
libminifi/src/utils/StringUtils.cpp:
##########
@@ -510,4 +511,20 @@ bool StringUtils::matchesSequence(std::string_view str,
const std::vector<std::s
return true;
}
+bool StringUtils::splitToUnitAndValue(std::string_view input, std::string&
unit, int64_t& value) {
+ const char* begin = input.data();
+ const char* end = begin + input.size();
Review Comment:
It does seem nicer however it failed to compile on MSVC so I've reverted it
back
https://github.com/apache/nifi-minifi-cpp/pull/1543/commits/c7d10838758e9b96631e8bbb99d5ad307e17bd8c
https://godbolt.org/z/jvs91f44o
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
