lordgamez commented on code in PR #1599:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1280379349
##########
libminifi/include/utils/net/Socket.h:
##########
Review Comment:
Updated in 1081ccfb9608f8f9dd7933cf48b66cb684276837
##########
libminifi/include/utils/net/Socket.h:
##########
Review Comment:
Updated in 1081ccfb9608f8f9dd7933cf48b66cb684276837
##########
libminifi/include/utils/net/Socket.h:
##########
@@ -23,86 +23,16 @@
#endif /* WIN32_LEAN_AND_MEAN */
#include <WinSock2.h>
#else
-#include <sys/types.h>
-#include <sys/socket.h>
Review Comment:
Updated in 1081ccfb9608f8f9dd7933cf48b66cb684276837
##########
libminifi/include/utils/net/DNS.h:
##########
Review Comment:
Updated in 1081ccfb9608f8f9dd7933cf48b66cb684276837
##########
libminifi/src/utils/net/DNS.cpp:
##########
Review Comment:
Updated in 1081ccfb9608f8f9dd7933cf48b66cb684276837
##########
libminifi/src/utils/net/DNS.cpp:
##########
@@ -127,4 +69,9 @@ nonstd::expected<std::string, std::error_code>
reverseDnsLookup(const asio::ip::
return results->host_name();
}
+std::string getMyHostName() {
+ static const std::string HOSTNAME = asio::ip::host_name();
+ return HOSTNAME;
+}
Review Comment:
I'm not sure how expensive is it, but as it should not change at all, I
think caching it wouldn't hurt.
##########
libminifi/src/utils/net/Socket.cpp:
##########
@@ -14,19 +14,15 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
#include "utils/net/Socket.h"
-#include "Exception.h"
-#include <cstring>
-#include <system_error>
+
#ifdef WIN32
-#ifndef WIN32_LEAN_AND_MEAN
-#define WIN32_LEAN_AND_MEAN
-#endif /* WIN32_LEAN_AND_MEAN */
Review Comment:
Updated in 1081ccfb9608f8f9dd7933cf48b66cb684276837
##########
libminifi/src/utils/net/Socket.cpp:
##########
@@ -14,19 +14,15 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
#include "utils/net/Socket.h"
-#include "Exception.h"
-#include <cstring>
Review Comment:
'<cstring>` is still there it was only moved a bit lower
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
