lordgamez commented on code in PR #1599:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1281622857
##########
libminifi/src/utils/net/DNS.cpp:
##########
@@ -127,4 +69,9 @@ nonstd::expected<std::string, std::error_code>
reverseDnsLookup(const asio::ip::
return results->host_name();
}
+std::string getMyHostName() {
+ static const std::string HOSTNAME = asio::ip::host_name();
+ return HOSTNAME;
+}
Review Comment:
Of course, but I'm not sure it is something we have to account for. But I
checked the runtimes and I couldn't see any difference between caching and not
caching the result so I removed it in 9ddaa71b8aecb723fc4c8eaaf49873a5939179f4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
