lordgamez commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1281594319
########## libminifi/include/core/state/nodes/DeviceInformation.h: ########## Review Comment: The logic was already moved in https://github.com/apache/nifi-minifi-cpp/pull/1602 but this is not yet rebased on that. After the dependency https://github.com/apache/nifi-minifi-cpp/pull/1595 is merged we can rebase and check if there are any headers left that could be moved to the cpp file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
