markap14 commented on code in PR #7661:
URL: https://github.com/apache/nifi/pull/7661#discussion_r1350586845
##########
nifi-system-tests/nifi-system-test-suite/src/test/java/org/apache/nifi/tests/system/clustering/JoinClusterWithDifferentFlow.java:
##########
@@ -236,20 +172,9 @@ private void verifyInMemoryFlowContents() throws
NiFiClientException, IOExceptio
assertEquals("65b8f293-016e-1000-7b8f-6c6752fa921b",
affectedComponent.getId());
assertEquals(AffectedComponentDTO.COMPONENT_TYPE_PROCESSOR,
affectedComponent.getReferenceType());
- // The original Controller Service, whose UUID ended with 00 should be
removed and a new one inherited.
- final ControllerServicesEntity controllerLevelServices =
node2Client.getFlowClient().getControllerServices();
- assertEquals(1,
controllerLevelServices.getControllerServices().size());
-
- final ControllerServiceEntity firstService =
controllerLevelServices.getControllerServices().iterator().next();
- assertFalse(firstService.getId().endsWith("00"));
- }
-
- private PropertyEncryptor createEncryptorFromProperties(Properties
properties) {
- final NiFiProperties niFiProperties =
NiFiProperties.createBasicNiFiProperties(null, properties);
-
- final String propertiesKey =
niFiProperties.getProperty(NiFiProperties.SENSITIVE_PROPS_KEY);
- final String propertiesAlgorithm =
niFiProperties.getProperty(NiFiProperties.SENSITIVE_PROPS_ALGORITHM);
- return new
PropertyEncryptorBuilder(propertiesKey).setAlgorithm(propertiesAlgorithm).build();
+ final ControllerServicesEntity controllerLevelServices =
getNifiClient().getFlowClient(DO_NOT_REPLICATE).getControllerServices();
+ final Set<ControllerServiceEntity> controllerServices =
controllerLevelServices.getControllerServices();
+ assertEquals(2, controllerServices.size());
Review Comment:
So you're saying that when using the XML form, the final result was 1
Controller Service. With the JSON form, it has two Controller Services, because
it didn't remove the service from the first flow?
If that is so, I would say that it's a bug. So I'd say that it would make
sense to:
1) Have the system test assert that the size is equal to 1.
2) Use @Disabled on the system test because we know it's not working
3) File a Jira to fix the issue and re-enable the system test.
This way, we can continue on and get this PR merged and avoid tackling other
(potentially complex) bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
