simonbence commented on code in PR #7661:
URL: https://github.com/apache/nifi/pull/7661#discussion_r1342363037
##########
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy:
##########
@@ -722,7 +707,7 @@ class ConfigEncryptionTool {
final PropertyEncryptor inputEncryptor = new
PropertyEncryptorBuilder(existingFlowPassword).setAlgorithm(existingAlgorithm).build()
final PropertyEncryptor outputEncryptor = new
PropertyEncryptorBuilder(newFlowPassword).setAlgorithm(newAlgorithm).build()
- final FlowEncryptor flowEncryptor = new StandardFlowEncryptor()
+ final FlowEncryptor flowEncryptor = new XmlFlowEncryptor()
Review Comment:
In this case I am not 100% sure if I get your intent.
`StandardFlowEncryptor` is (actually: was) a just a composite implementation
which helped NiFi decide is the `XmlFlowEncryptor` or the `JsonFlowEncryptor`
needs to be used. As `XmlFlowEncryptor` is not there anymore
`StandardFlowEncryptor` was deleted as well. In the other hand this toolkit
method needs an encryptor capable to work with XML, let it be
`XmlFlowEncryptor` directly or `StandardFlowEncryptor` (which will call
`XmlFlowEncryptor` in the background). So if we are willing to keep providing
this particular service (`migrateFlowXmlContent`) we need the
`XmlFlowEncryptor` in place. If this is your aim, I would limit it's scope to
the toolkit (I added back this way) and would not add back the composite
(`StandardFlowEncryptor`) as it provides no feature during the standard run of
NiFi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
