exceptionfactory commented on code in PR #7661:
URL: https://github.com/apache/nifi/pull/7661#discussion_r1342714169
##########
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy:
##########
@@ -385,26 +370,26 @@ class ConfigEncryptionTool {
}
}
- if (commandLine.hasOption(FLOW_XML_ARG)) {
- if (isVerbose) {
- logger.info("Handling encryption of flow.xml.gz")
- }
- flowXmlPath = commandLine.getOptionValue(FLOW_XML_ARG)
- outputFlowXmlPath =
commandLine.getOptionValue(OUTPUT_FLOW_XML_ARG, flowXmlPath)
- handlingFlowXml = true
-
- newFlowAlgorithm =
commandLine.getOptionValue(NEW_FLOW_ALGORITHM_ARG)
- newFlowProvider =
commandLine.getOptionValue(NEW_FLOW_PROVIDER_ARG)
-
- if (flowXmlPath == outputFlowXmlPath) {
- // TODO: Add confirmation pause and provide -y flag to
offer no-interaction mode?
- logger.warn("The source flow.xml.gz and destination
flow.xml.gz are identical [${outputFlowXmlPath}] so the original will be
overwritten")
- }
-
- if (!commandLine.hasOption(NIFI_PROPERTIES_ARG)) {
- printUsageAndThrow("In order to migrate a flow.xml.gz, a
nifi.properties file must also be specified via
'-n'/'--${NIFI_PROPERTIES_ARG}'.", ExitCode.INVALID_ARGS)
- }
- }
+// if (commandLine.hasOption(FLOW_XML_ARG)) {
+// if (isVerbose) {
+// logger.info("Handling encryption of flow.xml.gz")
+// }
+// flowXmlPath = commandLine.getOptionValue(FLOW_XML_ARG)
+// outputFlowXmlPath =
commandLine.getOptionValue(OUTPUT_FLOW_XML_ARG, flowXmlPath)
+// handlingFlowXml = true
+//
+// newFlowAlgorithm =
commandLine.getOptionValue(NEW_FLOW_ALGORITHM_ARG)
+// newFlowProvider =
commandLine.getOptionValue(NEW_FLOW_PROVIDER_ARG)
+//
+// if (flowXmlPath == outputFlowXmlPath) {
+// // TODO: Add confirmation pause and provide -y flag to
offer no-interaction mode?
+// logger.warn("The source flow.xml.gz and destination
flow.xml.gz are identical [${outputFlowXmlPath}] so the original will be
overwritten")
+// }
+//
+// if (!commandLine.hasOption(NIFI_PROPERTIES_ARG)) {
+// printUsageAndThrow("In order to migrate a flow.xml.gz, a
nifi.properties file must also be specified via
'-n'/'--${NIFI_PROPERTIES_ARG}'.", ExitCode.INVALID_ARGS)
+// }
+// }
Review Comment:
As noted in relation to the arguments, it looks like this can be uncommented
for this PR, and then other changes can be handled separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
