simonbence commented on code in PR #7661:
URL: https://github.com/apache/nifi/pull/7661#discussion_r1342367861


##########
nifi-toolkit/nifi-toolkit-encrypt-config/src/main/groovy/org/apache/nifi/properties/ConfigEncryptionTool.groovy:
##########
@@ -248,8 +235,6 @@ class ConfigEncryptionTool {
         
options.addOption(Option.builder("i").longOpt(OUTPUT_LOGIN_IDENTITY_PROVIDERS_ARG).hasArg(true).argName("file").desc("The
 destination login-identity-providers.xml file containing protected config 
values (will not modify input login-identity-providers.xml)").build())
         
options.addOption(Option.builder("a").longOpt(AUTHORIZERS_ARG).hasArg(true).argName("file").desc("The
 authorizers.xml file containing unprotected config values (will be overwritten 
unless -u is specified)").build())
         
options.addOption(Option.builder("u").longOpt(OUTPUT_AUTHORIZERS_ARG).hasArg(true).argName("file").desc("The
 destination authorizers.xml file containing protected config values (will not 
modify input authorizers.xml)").build())
-        
options.addOption(Option.builder("f").longOpt(FLOW_XML_ARG).hasArg(true).argName("file").desc("The
 flow.xml.gz file currently protected with old password (will be overwritten 
unless -g is specified)").build())
-        
options.addOption(Option.builder("g").longOpt(OUTPUT_FLOW_XML_ARG).hasArg(true).argName("file").desc("The
 destination flow.xml.gz file containing protected config values (will not 
modify input flow.xml.gz)").build())

Review Comment:
   Yes, as mentioned in the description, originally I wanted to do the toolkit 
changes in a follow up story after clarifying the cleanup and general changes 
within this PR. Depending on your answer for my comment above hovere I will 
change this part accordingly. For further toolkit related changes I suggest to 
move them in a followup PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to