scottyaslan commented on code in PR #8766:
URL: https://github.com/apache/nifi/pull/8766#discussion_r1594323472
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/controller-service/controller-service-table/controller-service-table.component.html:
##########
@@ -116,62 +116,73 @@
<ng-container matColumnDef="actions">
<th mat-header-cell *matHeaderCellDef></th>
<td mat-cell *matCellDef="let item">
- @if (definedByCurrentGroup(item)) {
- <div class="flex items-center justify-end gap-x-2">
- <div
- class="pointer fa fa-cog primary-color"
- (click)="configureClicked(item, $event)"
- [title]="canConfigure(item) ? 'Edit' : 'View
Configuration'"></div>
- @if (hasAdvancedUi(item)) {
- <div
- class="pointer fa fa-cogs primary-color"
- (click)="advancedClicked(item, $event)"
- title="Advanced"></div>
+ <div class="flex items-center justify-end gap-x-2">
+ <button
+ mat-icon-button
+ type="button"
+ [matMenuTriggerFor]="actionMenu"
+ class="h-16 w-16 flex items-center justify-center
icon global-menu">
+ <i class="fa fa-ellipsis-v"></i>
+ </button>
+ <mat-menu #actionMenu="matMenu" xPosition="before">
+ @if (definedByCurrentGroup(item)) {
+ <button mat-menu-item
(click)="configureClicked(item, $event)">
+ <i class="fa fa-cog primary-color
mr-2"></i>
+ {{ canConfigure(item) ? 'Edit' : 'View
Configuration' }}
+ </button>
+ @if (hasAdvancedUi(item)) {
+ <button mat-menu-item
(click)="advancedClicked(item, $event)">
+ <i class="fa fa-cogs primary-color
mr-2"></i>
+ Advanced
+ </button>
+ }
+ @if (canDisable(item)) {
+ <button mat-menu-item
(click)="disableClicked(item)">
+ <i class="icon icon-enable-false
primary-color mr-2"></i>
+ Disable
+ </button>
+ }
+ @if (canEnable(item)) {
+ <button mat-menu-item
(click)="enabledClicked(item)">
+ <i class="fa fa-flash primary-color
mr-2"></i>
+ Enable
+ </button>
+ }
+ @if (canChangeVersion(item)) {
+ <button mat-menu-item
(click)="changeVersionClicked(item)">
+ <i class="fa fa-exchange primary-color
mr-2"></i>
+ Change Version
+ </button>
+ }
+ @if (canDelete(item)) {
+ <button mat-menu-item
(click)="deleteClicked(item, $event)">
+ <i class="fa fa-trash primary-color
mr-2"></i>
+ Delete
Review Comment:
This happens anywhere we `event.stopPropagation();`. I think these were in
place to not cause selection to fire. I will remove them.
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/ui/reporting-tasks/reporting-task-table/reporting-task-table.component.html:
##########
@@ -111,53 +111,64 @@
<th mat-header-cell *matHeaderCellDef></th>
<td mat-cell *matCellDef="let item">
<div class="flex items-center justify-end gap-x-2">
- <div
- class="pointer fa fa-cog primary-color"
- (click)="configureClicked(item, $event)"
- [title]="canEdit(item) ? 'Edit' : 'View
Configuration'"></div>
- @if (hasAdvancedUi(item)) {
- <div
- class="pointer fa fa-cogs primary-color"
- (click)="advancedClicked(item, $event)"
- title="Advanced"></div>
- }
- @if (canStop(item)) {
- <div
- class="pointer fa fa-stop primary-color"
- (click)="stopClicked(item)"
- title="Stop"></div>
- }
- @if (canStart(item)) {
- <div
- class="pointer fa fa-play primary-color"
- (click)="startClicked(item)"
- title="Start"></div>
- }
- @if (canChangeVersion(item)) {
- <div
- class="pointer fa fa-exchange primary-color"
- (click)="changeVersionClicked(item)"
- title="Change Version"></div>
- }
- @if (canDelete(item)) {
- <div
- class="pointer fa fa-trash primary-color"
- (click)="deleteClicked(item)"
- title="Delete"></div>
- }
- @if (canViewState(item)) {
- <div
- class="pointer fa fa-tasks primary-color"
- (click)="viewStateClicked(item)"
- title="View State"></div>
- }
- @if (canManageAccessPolicies()) {
- <div
- class="pointer fa fa-key primary-color"
- (click)="$event.stopPropagation()"
- [routerLink]="getPolicyLink(item)"
- title="Access Policies"></div>
- }
+ <button
+ mat-icon-button
+ type="button"
+ [matMenuTriggerFor]="actionMenu"
+ class="h-16 w-16 flex items-center justify-center
icon global-menu">
+ <i class="fa fa-ellipsis-v"></i>
+ </button>
+ <mat-menu #actionMenu="matMenu" xPosition="before">
+ <button mat-menu-item
(click)="configureClicked(item, $event)">
+ <i class="fa fa-cog primary-color mr-2"></i>
+ {{ canEdit(item) ? 'Edit' : 'View
Configuration' }}
Review Comment:
https://github.com/apache/nifi/pull/8766#discussion_r1594323472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
