rfellows commented on code in PR #8766:
URL: https://github.com/apache/nifi/pull/8766#discussion_r1594348911
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/users/ui/user-listing/user-table/user-table.component.html:
##########
@@ -79,24 +79,37 @@
<th mat-header-cell *matHeaderCellDef></th>
<td mat-cell *matCellDef="let item">
<div class="flex items-center justify-end gap-x-2">
- @if (canEditOrDelete(currentUser, item)) {
- <div
- class="pointer fa fa-cog primary-color"
- title="Edit"
- (click)="editClicked(item, $event)"></div>
- }
- @if (canEditOrDelete(currentUser, item)) {
- <div
- class="pointer fa fa-trash primary-color"
- title="Remove"
- (click)="deleteClicked(item)"></div>
- }
- @if (hasAccessPolicies(item)) {
- <div
- class="pointer fa fa-key primary-color"
- title="View User Policies"
- (click)="viewAccessPoliciesClicked(item,
$event)"></div>
+ @if (
+ canEditOrDelete(currentUser, item) ||
hasAccessPolicies(item) || hasAccessPolicies(item)
+ ) {
+ <button
+ mat-icon-button
+ type="button"
+ [matMenuTriggerFor]="actionMenu"
+ class="h-16 w-16 flex items-center
justify-center icon global-menu">
+ <i class="fa fa-ellipsis-v"></i>
+ </button>
}
+ <mat-menu #actionMenu="matMenu" xPosition="before">
+ @if (canEditOrDelete(currentUser, item)) {
+ <button mat-menu-item
(click)="editClicked(item)">
+ <i class="fa fa-cog primary-color
mr-2"></i>
+ Edit
+ </button>
+ }
+ @if (canEditOrDelete(currentUser, item)) {
+ <button mat-menu-item
(click)="deleteClicked(item)">
+ <i class="fa fa-trash primary-color
mr-2"></i>
+ Remove
+ </button>
+ }
+ @if (hasAccessPolicies(item)) {
+ <button mat-menu-item
(click)="viewAccessPoliciesClicked(item)">
+ <i class="fa fa-key primary-color
mr-2"></i>
+ Manage Access Policies
Review Comment:
This might not be the correct phrase. It doesn't open the policies page like
the other ones do. it opens a dialog with the user policies. It might be best
to leave this one as `Manage User Policies` to draw a distinction.
<img width="783" alt="Screenshot 2024-05-08 at 1 05 00 PM"
src="https://github.com/apache/nifi/assets/713866/4543448d-1e50-47bf-ba8e-a8dfab5cf89a";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
