scottyaslan commented on code in PR #8766:
URL: https://github.com/apache/nifi/pull/8766#discussion_r1594324132
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/parameter-contexts/ui/parameter-context-listing/parameter-context-table/parameter-context-table.component.html:
##########
@@ -58,32 +58,52 @@
<th mat-header-cell *matHeaderCellDef></th>
<td mat-cell *matCellDef="let item">
<div class="flex items-center justify-end gap-x-2">
- @if (canRead(item)) {
- <div
- class="pointer fa fa-cog primary-color"
- (click)="editClicked(item, $event)"
- [title]="canWrite(item) ? 'Edit' : 'View
Configuration'"></div>
- }
- @if (canDelete(item)) {
- <div
- class="pointer fa fa-trash primary-color"
- (click)="deleteClicked(item, $event)"
- title="Delete"></div>
- }
- @if (canManageAccessPolicies()) {
- <div
- class="pointer fa fa-key primary-color"
- (click)="$event.stopPropagation()"
- [routerLink]="getPolicyLink(item)"
- title="Access Policies"></div>
- }
- @if (canGoToParameterProvider(item)) {
- <div
- class="pointer fa fa-long-arrow-right
primary-color"
- (click)="$event.stopPropagation()"
- [routerLink]="getParameterProviderLink(item)"
- title="Go to Parameter Provider"></div>
+ @if (
+ canRead(item) ||
+ canDelete(item) ||
+ canManageAccessPolicies() ||
+ canGoToParameterProvider(item)
+ ) {
+ <button
+ mat-icon-button
+ type="button"
+ [matMenuTriggerFor]="actionMenu"
+ class="h-16 w-16 flex items-center
justify-center icon global-menu">
+ <i class="fa fa-ellipsis-v"></i>
+ </button>
}
+ <mat-menu #actionMenu="matMenu" xPosition="before">
+ @if (canRead(item)) {
+ <button mat-menu-item
(click)="editClicked(item, $event)">
+ <i class="fa fa-cog primary-color
mr-2"></i>
+ {{ canWrite(item) ? 'Edit' : 'View
Configuration' }}
+ </button>
Review Comment:
https://github.com/apache/nifi/pull/8766#discussion_r1594323472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
