scottyaslan commented on code in PR #8766:
URL: https://github.com/apache/nifi/pull/8766#discussion_r1594323808
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/users/ui/user-listing/user-table/user-table.component.html:
##########
@@ -79,24 +79,37 @@
<th mat-header-cell *matHeaderCellDef></th>
<td mat-cell *matCellDef="let item">
<div class="flex items-center justify-end gap-x-2">
- @if (canEditOrDelete(currentUser, item)) {
- <div
- class="pointer fa fa-cog primary-color"
- title="Edit"
- (click)="editClicked(item, $event)"></div>
- }
- @if (canEditOrDelete(currentUser, item)) {
- <div
- class="pointer fa fa-trash primary-color"
- title="Remove"
- (click)="deleteClicked(item)"></div>
- }
- @if (hasAccessPolicies(item)) {
- <div
- class="pointer fa fa-key primary-color"
- title="View User Policies"
- (click)="viewAccessPoliciesClicked(item,
$event)"></div>
+ @if (
+ canEditOrDelete(currentUser, item) ||
hasAccessPolicies(item) || hasAccessPolicies(item)
+ ) {
+ <button
+ mat-icon-button
+ type="button"
+ [matMenuTriggerFor]="actionMenu"
+ class="h-16 w-16 flex items-center
justify-center icon global-menu">
+ <i class="fa fa-ellipsis-v"></i>
+ </button>
}
+ <mat-menu #actionMenu="matMenu" xPosition="before">
Review Comment:
https://github.com/apache/nifi/pull/8766#discussion_r1594323472
##########
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/processor-status-listing/processor-status-table/processor-status-table.component.html:
##########
@@ -248,25 +248,36 @@
<th mat-header-cell *matHeaderCellDef></th>
<td mat-cell *matCellDef="let item">
<div class="flex items-center justify-end
gap-x-2">
- <div
- class="pointer fa
fa-long-arrow-right primary-color"
-
[routerLink]="getProcessorLink(item)"
- (click)="$event.stopPropagation()"
- title="Go to Processor in {{
-
item?.processorStatusSnapshot?.processGroupNamePath
- }}"></div>
+ <button
+ mat-icon-button
+ type="button"
+ [matMenuTriggerFor]="actionMenu"
+ class="h-16 w-16 flex items-center
justify-center icon global-menu">
+ <i class="fa fa-ellipsis-v"></i>
+ </button>
+ <mat-menu #actionMenu="matMenu"
xPosition="before">
Review Comment:
https://github.com/apache/nifi/pull/8766#discussion_r1594323472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
