joewitt commented on code in PR #8892:
URL: https://github.com/apache/nifi/pull/8892#discussion_r1619060507


##########
nifi-assembly/pom.xml:
##########
@@ -350,6 +350,42 @@ language governing permissions and limitations under the 
License. -->
             <version>2.0.0-SNAPSHOT</version>
             <type>nar</type>
         </dependency>
+        <dependency>
+            <groupId>org.apache.nifi</groupId>
+            <artifactId>nifi-generic-db-adapter-provider-nar</artifactId>
+            <version>2.0.0-SNAPSHOT</version>
+            <type>nar</type>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.nifi</groupId>
+            <artifactId>nifi-oracle-db-adapter-provider-nar</artifactId>

Review Comment:
   Is the word 'provider' helpful in these?  
   
   It seems to me we have database adapter api and database adapters that 
implement the api.  Ie we have
   
   nifi-database-adapter-api is the api module.
   
   nifi-oracle-db-adapter-nar implements the api specific to oracle 
column/types.
   
   Provider seems not needed.  Can you share more if that is helpful?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to