joewitt commented on code in PR #8892:
URL: https://github.com/apache/nifi/pull/8892#discussion_r1619329171


##########
nifi-assembly/pom.xml:
##########
@@ -350,6 +350,42 @@ language governing permissions and limitations under the 
License. -->
             <version>2.0.0-SNAPSHOT</version>
             <type>nar</type>
         </dependency>
+        <dependency>
+            <groupId>org.apache.nifi</groupId>
+            <artifactId>nifi-generic-db-adapter-provider-nar</artifactId>
+            <version>2.0.0-SNAPSHOT</version>
+            <type>nar</type>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.nifi</groupId>
+            <artifactId>nifi-oracle-db-adapter-provider-nar</artifactId>

Review Comment:
   I dont think I realized we had a 'database-adapter-api' and a 
'database-adapter-provider-api'. 
   
   The word 'adapter' is generic/broad as is 'provider' so it just looks odd 
having them both side by side.
   
   I dont know enough about why we need these two separate APIs so I guess I'll 
back out of this comment for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to