takraj commented on code in PR #8892:
URL: https://github.com/apache/nifi/pull/8892#discussion_r1619227955
##########
nifi-assembly/pom.xml:
##########
@@ -350,6 +350,42 @@ language governing permissions and limitations under the
License. -->
<version>2.0.0-SNAPSHOT</version>
<type>nar</type>
</dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-generic-db-adapter-provider-nar</artifactId>
+ <version>2.0.0-SNAPSHOT</version>
+ <type>nar</type>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.nifi</groupId>
+ <artifactId>nifi-oracle-db-adapter-provider-nar</artifactId>
Review Comment:
I'm fine with removing the word 'provider' from the controller services, but
I'm not sure if it's a good practice, since we have actual 'adapter' classes,
that are instantiated by the 'provider' classes. If you feel like you have
better wording for this concept, then I'm OK with renaming.
Or did you mean this 'adapter' - 'provider' abstraction does not seem
useful? IMHO it adds some flexibility to how we organize, or combine various
adapters, because for example a single controller service for MSSQL can provide
adapters for multiple versions of that dialect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
