martinzink commented on code in PR #1805: URL: https://github.com/apache/nifi-minifi-cpp/pull/1805#discussion_r1624003333
########## .gitignore: ########## @@ -65,6 +65,12 @@ __pycache__/ /provenance_repository /logs msi/WixWin.wsi +extensions/expression-language/el-scanner/Scanner.cpp +extensions/expression-language/el-parser/Parser.cpp +extensions/expression-language/el-parser/Parser.hpp +extensions/expression-language/el-parser/location.hh +extensions/expression-language/el-parser/position.hh +extensions/expression-language/el-parser/stack.hh Review Comment: Why did you extract the local gitignore to this root one? I prefered the previous approach, because it was more modular. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
