szaszm commented on code in PR #1805:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1805#discussion_r1624596338


##########
extensions/expression-language/CMakeLists.txt:
##########
@@ -96,20 +96,22 @@ find_package(FLEX REQUIRED)
 bison_target(
     el-parser
     ${CMAKE_CURRENT_SOURCE_DIR}/Parser.yy
-    ${CMAKE_CURRENT_SOURCE_DIR}/Parser.cpp
+    ${CMAKE_CURRENT_SOURCE_DIR}/el-parser/Parser.cpp
 )
 
 flex_target(
     el-scanner
     ${CMAKE_CURRENT_SOURCE_DIR}/Scanner.ll
-    ${CMAKE_CURRENT_SOURCE_DIR}/Scanner.cpp
+    ${CMAKE_CURRENT_SOURCE_DIR}/el-scanner/Scanner.cpp
     COMPILE_FLAGS --c++
 )
 
 add_flex_bison_dependency(el-scanner el-parser)
 
 include_directories(./ ../../libminifi/include  ../../libminifi/include/core)
 include_directories(SYSTEM ../../thirdparty/)
+include_directories(SYSTEM el-parser)
+include_directories(SYSTEM el-scanner)

Review Comment:
   Ok, got it. But I still thing that we should not add directory-based include 
paths, and add them to each target as necessary. It would also be nicer to 
generate these files under the build directory, instead of the source tree.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to