lordgamez commented on code in PR #1805:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1805#discussion_r1624579558


##########
extensions/expression-language/CMakeLists.txt:
##########
@@ -96,20 +96,22 @@ find_package(FLEX REQUIRED)
 bison_target(
     el-parser
     ${CMAKE_CURRENT_SOURCE_DIR}/Parser.yy
-    ${CMAKE_CURRENT_SOURCE_DIR}/Parser.cpp
+    ${CMAKE_CURRENT_SOURCE_DIR}/el-parser/Parser.cpp
 )
 
 flex_target(
     el-scanner
     ${CMAKE_CURRENT_SOURCE_DIR}/Scanner.ll
-    ${CMAKE_CURRENT_SOURCE_DIR}/Scanner.cpp
+    ${CMAKE_CURRENT_SOURCE_DIR}/el-scanner/Scanner.cpp
     COMPILE_FLAGS --c++
 )
 
 add_flex_bison_dependency(el-scanner el-parser)
 
 include_directories(./ ../../libminifi/include  ../../libminifi/include/core)
 include_directories(SYSTEM ../../thirdparty/)
+include_directories(SYSTEM el-parser)
+include_directories(SYSTEM el-scanner)

Review Comment:
   Previously we generated the parser and scanner header and source files into 
the `extensions/expression-language/` directory and the files in that directory 
were compiled with the flags handling warnings as errors. Because of this when 
some warnings were found in the generated header files included by our own 
source files that resulted in a compile error. Moving the generated files to 
separate include directories and marking them as system includes ignores the 
warnings in those header files.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to