lordgamez commented on code in PR #1805:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1805#discussion_r1624573494


##########
extensions/sftp/processors/PutSFTP.cpp:
##########


Review Comment:
   On Windows the previous version didn't compile as std::filesystem::path 
cannot be converted implicitly to string, that is why we had to use the 
`.string()`. Even if it is changed to `.string().c_str()` wouldn't it still 
result in extra allocations?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to