james94 commented on code in PR #1793: URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#discussion_r1632094367
########## CMakeLists.txt: ########## Review Comment: @szaszm I just realized I had a forgot to update the **USE_CONAN_PACKAGER** in the conanfile.py to be **MINIFI_USE_CONAN_PACKAGER** variable. Thats why we were seeing the OpenSSL, ZLib, and LibCURL being built from source instead of using the conan prebuilt versions. I just updated the conanfile.py. I have shared the output from when I ran `conan install . --build=missing --output-folder=build_conan` similar to how you did using the **default conan profile**. I also attached the output from running the conan build. You'll see this time, MiNiFi conan cmake uses conan's prebuilt packages for OpenSSL, ZLib and LibCURL instead of building them from source. [conan_install_default_profile_jguzman_060824.log](https://github.com/user-attachments/files/15749397/conan_install_default_profile_jguzman_060824.log) [conan_build_default_profile_jguzman_060824.log](https://github.com/user-attachments/files/15749398/conan_build_default_profile_jguzman_060824.log) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
