james94 commented on code in PR #1793: URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#discussion_r1632101312
########## conanfile.py: ########## Review Comment: I agree with your suggestion for now that for all the feature selection options that are not **OpenSSL, CURL, ZLib**, we go with the default selected options currently in MiNiFiOptions.cmake and for now we use the normal **FetchContent/ExternalProject** for the rest of MiNiFi C++ external lib dependencies. Yes sounds good. For now, I will leave the default enabled MiNiFi Options set as they are in MiNiFiOptions.cmake and remove the **tc.variables[...]** ones from conanfile.py. We will only bring in **tc.variables[...]** variables when we are overriding one of the existing MiNiFi options from the CMake side with conan. This will only be relevant for the new MiNiFi options we discussed above for example **MINIFI_LIBCURL_SOURCE** and the other 2 libs sources. @szaszm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
