james94 commented on code in PR #1793:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#discussion_r1628099101
##########
CMakeLists.txt:
##########
Review Comment:
Ah I see. If you ran into an issue with finding the conan_toolchain.cmake,
then that could make sense why OpenSSL and Zlib were built from source instead
of using the conan packages. Heres a snippet from the conanfile.py relevant to
conan_toolchain:
~~~python
tc = CMakeToolchain(self)
tc.variables["MINIFI_USE_CONAN_PACKAGER"] = "ON"
~~~
If the CMakeToolchain() failed to be created due to not being able to find
the conan_toolchain.cmake, then the **MINIFI_USE_CONAN_PACKAGER = "ON"**
wouldn't have happened and thus we would see that the OpenSSL and Zlib sources
are used instead of conan package. I will try out your steps to see if I run
into the issues you ran into.
I do want to note that I did use a conan profile along minifi path
`nifi-minifi-cpp/etc/build/conan/profiles/release-linux`, so its common amongst
build environments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
