james94 commented on code in PR #1793:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#discussion_r1632118893
##########
conanfile.py:
##########
Review Comment:
@szaszm I updated MiNiFiOptions.cmake with 3 new options for instance
MINIFI_LIBCURL_SOURCE and I am using MiNiFi options default ones for Enabled
options. In the case of RocksDB, when building using the default conan profile,
I run into an issue where it complains that I need to use at least gnu20. This
issue happened because my default conan profile was using gnu17. This is why I
was suggesting we use a common conan profile that is already defined in MiNiFi
C++ that is already set to use gnu20. If I dont use the predefined conan
profile for MiNiFi located in `etc/conan/profiles/release-linux`, then I get
this following RocksDB error:
~~~bash
/home/ubuntu/src/james/pipeline/nifi-minifi-cpp-conan2/build_conan/thirdparty/rocksdb-src/include/rocksdb/options.h:400:8:
error: defaulted ‘bool rocksdb::DbPath::operator==(const rocksdb::DbPath&)
const’ only available with ‘-std=c++20’ or ‘-std=gnu++20’
400 | bool operator==(const DbPath& other) const = default;
| ^~~~~~~~
/home/ubuntu/src/james/pipeline/nifi-minifi-cpp-conan2/build_conan/thirdparty/rocksdb-src/include/rocksdb/options.h:1012:8:
error: defaulted ‘bool rocksdb::DBOptions::operator==(const
rocksdb::DBOptions&) const’ only available with ‘-std=c++20’ or ‘-std=gnu++20’
1012 | bool operator==(const DBOptions& other) const = default;
| ^~~~~~~~
~~~
Therefore, I suggest we use a common conan profile
`etc/conan/profiles/release-linux` @szaszm
Heres the command, which is also at the beginning of my PR:
~~~bash
conan build . --build=missing --output-folder=build_conan
-pr=etc/conan/profiles/release-linux
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
