szaszm commented on code in PR #1793: URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#discussion_r1661078485
########## conanfile.py: ########## Review Comment: I would change the default CMake target to `package` when building with Conan. When using CMake directly, the user can just call `make` or `make package` as they wish. But since it's not possible, or not immediately obvious how to do this with `conan build`, I'd do a build that's as complete as possible. ########## conanfile.py: ########## Review Comment: just a random thought: I don't want any of the changes to prevent future adoption of vcpkg, as it seems to be the more popular c++ package manager. Do you think this would be possible? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
