james94 commented on code in PR #1793: URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#discussion_r1667607551
########## conanfile.py: ########## Review Comment: I believe conan's equivalent to CMake's `make package` is leveraging conan's ConanFile class's **package(...)** method and making sure it comes with all the headers, binaries, etc that would be included when running `make package`. I will check MiNiFi's `make package` to verify that ConanFile class's **package(...)** creates a MiNiFi C++ conan package with the similar assets. For reference, here is my follow up PR that works toward this effort: - "MINIFICPP-2346-P2" **PR-1813** Follow Up to "MINIFICPP-2346-P1": https://github.com/apache/nifi-minifi-cpp/pull/1813 - You'll notice a lot of changes in the diff, but that is because I haven't rebased on top of latest main branch, which I will do once we get this PR merged. I can incorporate the ConanFile class's **package()** here to add the ability to run `conan create`, which is similar to `make package`. I will try to keep the changes to a minimum too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
