james94 commented on code in PR #1793: URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#discussion_r1712666278
########## test_package/src/AbstractProcessorTest.cpp: ########## @@ -0,0 +1,114 @@ +/** Review Comment: I realized I forgot to add this conan test_package/ folder that comes with an example **AbstractProcessorTest.cpp**, which is the same one from the MiNiFi GTESTs. This helps us test if features are available from the MiNiFi conan package. We can simulate if we were to add MiNiFi C++ library to a C++ project, would the features we need be available to it. For now, I just copied this AbstractProcessorTest.cpp GTEST example. This test_package/ comes with CMakeLists.txt and its own conanfile.py too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
