james94 commented on code in PR #1793: URL: https://github.com/apache/nifi-minifi-cpp/pull/1793#discussion_r1718946350
########## test_package/src/AbstractProcessorTest.cpp: ########## @@ -0,0 +1,114 @@ +/** Review Comment: I decided to leave out the **cmake.ctest()** from being run automatically after conan finishes building MiNiFi C++, so the user will still need to go into **build_conan** folder and then run **ctest**. For the conan build and conan create approaches for MiNiFi C++, **217/219** TESTs PASS. For standalone CMake approach, **275/275** TESTs PASS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
